@pablobm commented on this pull request.
> @@ -226,6 +228,16 @@ L.OSM.share = function (options) {
const precision = 5 * Math.pow(10, Math.floor(Math.LOG10E *
Math.log(scale)) - 2);
return precision * Math.ceil(scale / precision);
}
+
+ function askToHandleGeoURI() {
+ if (sessionStorage.getItem("wasAbleToAskForHandler")) return;
+ try {
+ navigator.registerProtocolHandler("geo", "/?geouri=%s");
+ sessionStorage.setItem("wasAbleToAskForHandler", "yes");
+ } catch (e) {
+ sessionStorage.setItem("wasAbleToAskForHandler", "no");
Why yes/no? I would have expected a simple boolean like
`askedForHandler=true|false`. Are we expecting to use the "no" value at some
point?
Also: should the key have a more specific name? Could there be other "handlers"
in the future? I was thinking something like `askedForGeoProtocolHandler`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5968#pullrequestreview-3273101633
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/5968/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
