@tomhughes commented on this pull request.
As I said before I think the structure of the commits here is wrong - rather
than removing the old assets and commenting out the code in the first commit
and then rewriting things and re-enabling the code in the second I would
reverse things and have the first commit rework the code and the the second one
clean up the now unused assets, style rules etc.
Long term it would be nice to see if we could generate the HTML on the server
side and just attach event handlers in the client but I think we can tackle
that separately.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6410#pullrequestreview-3332267312
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6410/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
