@pablobm commented on this pull request.
> +gem "opentelemetry-exporter-otlp"
+gem "opentelemetry-instrumentation-all"
+gem "opentelemetry-sdk"
These are `require`d by default. If we are going to `require` them only when
`OTEL_TRACES_EXPORTER` is defined, then we should add `require: false` to each:
```suggestion
gem "opentelemetry-exporter-otlp", require: false
gem "opentelemetry-instrumentation-all", require: false
gem "opentelemetry-sdk", require: false
```
You can verify this by running: `bin/rails runner OpenTelemetry::SDK`. With the
code in this PR, it runs without a complaint. If you add the `require: false`
you'll see it end with `uninitialized constant OpenTelemetry`.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6405#pullrequestreview-3251320958
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6405/review/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
