gravitystorm left a comment (openstreetmap/openstreetmap-website#6410)
This looks great, and I'm happy to merge it as-is.
I'm happy to see the bootstrap-icons dependency, and I hope this makes it
easier for other developers to add icons elsewhere in the site, where they are
useful.
I'm going to create a follow-up issue about making our icons more consistent,
since several items on the menu have icons which don't match the icons
elsewhere in the UI. However, I didn't feel like these inconsistencies should
block the merging of this PR, which was substantially concerned with changing
the implementation. We can discuss and iterate the icons separately.
I also agree with Tom that it would be good to make the html generated in a
view, where it's easier for most developers to find and adjust, but that can
also be tackled separately.
Thanks @mmd-osm for your work on this!
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6410#issuecomment-3461974688
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6410/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
