@Copilot commented on this pull request.
## Pull request overview
This PR successfully migrates the edit location page from Leaflet to MapLibre
GL JS, modernizing the mapping library while maintaining functionality. The
migration includes coordinate system adjustments, API method updates, and
improvements to the zoom behavior with exponential easing.
Key changes:
- Replaced Leaflet-specific map controls with MapLibre equivalents
(NavigationControl, GeolocateControl)
- Updated coordinate handling from Leaflet's lat/lng order to MapLibre's
lng/lat order throughout
- Disabled rotation features (roll, drag rotate, pitch) for better location
selection UX
---
💡 <a
href="/openstreetmap/openstreetmap-website/new/master/.github/instructions?filename=*.instructions.md"
class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add
Copilot custom instructions</a> for smarter, more guided reviews. <a
href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot";
class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how
to get started</a>.
> marker.addTo(map);
- map.panTo([lat, lon]);
+ map.panTo([lon, lat]);
MapLibre GL JS does not have a `panTo` method. This will cause a runtime error
when the function is called. Use `easeTo` for smooth panning or `jumpTo` for
instant movement. For example: `map.easeTo({ center: [lon, lat] })` or
`map.jumpTo({ center: [lon, lat] })`.
```suggestion
map.easeTo({ center: [lon, lat] });
```
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6675#pullrequestreview-3625145859
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6675/review/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
