aNsHuL5217 left a comment (openstreetmap/openstreetmap-website#6681)
> I'm looking into this. I plan to proceed with the second suggestion mentioned
> in the description refactoring the `createMenuItem` function to support
> inline SVGs or image tags.
>
> This seems like the best approach to ensure the context menu icons for "Add a
> note" (speech bubble with a plus sign) and "Query features" (cursor arrow
> with a small question mark) exactly match the custom SVGs used in the
> sidebar, rather than relying on approximate Bootstrap matches.
I agree that refactoring `createMenuItem` to support inline SVGs (or image
tags) is the right way forward here. Reusing the exact same SVG assets as the
sidebar will give us proper visual consistency and avoids trying to approximate
them with Bootstrap icons.
I’d suggest keeping the existing Bootstrap-based behavior intact and extending
`createMenuItem` in a generic way to handle SVGs, rather than special-casing
individual menu items. That should keep the change clean and maintainable.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6681#issuecomment-3722756863
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/issues/6681/[email protected]>
_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
