gravitystorm left a comment (openstreetmap/openstreetmap-website#6424)
I've tried this out today, using
[`@devcontainers/cli`](https://www.npmjs.com/package/@devcontainers/cli) and it
worked for me. I successfully ran the entire test suite, and I got `rails
server` working after a couple of small tweaks.
<details><summary>devcontainers-cli specific notes</summary>
<p>
The port forwarding is not supported by @devcontainers/cli ( see
https://github.com/devcontainers/cli/issues/186 and
https://github.com/devcontainers/cli/issues/22) but this can be worked around.
First, launch the server bound to all IP addresses, not just localhost within
the container, i.e. `bundle exec rails server -b 0.0.0.0`. Secondly, add the
port forwarding to the compose file, i.e.
```diff
--- a/.devcontainer/compose.yaml
+++ b/.devcontainer/compose.yaml
@@ -6,6 +6,9 @@ services:
context: ..
dockerfile: .devcontainer/Dockerfile
+ ports:
+ - "3000:3000"
+
volumes:
- ../..:/workspaces:cached
- mise-cache:/home/vscode/.local/share/mise
```
It would be great if `cli` had the port forwarding built in, since it would
then be an easy substitute for having our standalone docker config - it will
suit many people who might want to use Docker but who aren't interested in the
IDE side of things.
</p>
</details>
My next plan is to test with [DevPod](https://devpod.sh/) to see how the IDE
integration side of things works.
But from my side, this looks good to me. What are the current blockers, if any?
Are there any other specific things you want tested?
Since this PR is additive, should we merge this and iron out any kinks later?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6424#issuecomment-3722957391
You are receiving this because you are subscribed to this thread.
Message ID:
<openstreetmap/openstreetmap-website/pull/6424/[email protected]>_______________________________________________
rails-dev mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/rails-dev
