Now I'm really confused, as I wasn't having any of those problems. And I didn't refactor anything... strange. Anyway, glad you guys figured out the problem and solved it! :-)
rahul -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jon Tirsen Sent: Wednesday, October 26, 2005 5:31 PM To: [email protected] Subject: Re: [Rails-spinoffs] InPlaceEditor scrolls to top in Firefox? Oh yeah! That works perfectly! Thanks Michael! Once again, use the latest patch from here: http://dev.rubyonrails.com/ticket/2616 On 10/27/05, Michael Zachariassen Krog <[EMAIL PROTECTED]> wrote: > Hum... > > Just an Idea... > Would it work if the focus were made by a setTimeout? > Im thinking that since it works if an alert is shown before, maybe > all it needs > is time to set everything right in the DOM. A setTimeout might do the > trick! > > -Michael > > > Den 26/10/2005 kl. 22.56 skrev Jon Tirsen: > > > Removing the Field.focus does indeed solve the scrolling issue. That > > does seem to be a bug, I mean if you focus a field you don't want to > > scroll to the top do you? How shall we work around this? Conditionally > > not do the focus if we're on Firefox? Isn't that really ugly? Ideas? > > > > On 10/27/05, Jay Levitt <[EMAIL PROTECTED]> wrote: > > > >> Rahul Bhargava wrote: > >> > >> > >>> this.form = this.getForm(); > >>> > >>> > >>> > >> I'm guessing you've refactored createForm into getForm? What's it > >> look > >> like? > >> > >> > >>> this.element.parentNode.insertBefore(this.form, this.element); > >>> Field.focus(this.editField); > >>> // stop the event to avoid a page refresh in Safari > >>> if(evt) Event.stop(evt); > >>> }, > >>> That worked perfectly for me in Firefox and IE on Windows. By > >>> "perfectly" I mean that it didn't scroll to the top at any point). > >>> > >>> > >> Switching that to createForm and trying it got me the same problem - > >> scrolls up. > >> > >> > >>> For completeness, anyone got ideas on why the standard arguments var > >>> check doesn't work? > >>> > >>> > >> Are you sure that's not just a function of the way .inspect works, > >> vs. the magic of "arguments"? I see the same thing in an alert or > >> in an inline debug, but Venkman's watch list shows it normally, > >> and a plain "alert(arguments.length)" yields "1". > >> > >> By sticking alerts on every line, I can see that Firefox scrolls > >> up at Field.focus(this.editField) - but NOT if it's already shown > >> an alert! So maybe it is a Firefox bug. But hopefully we can > >> work around it... does this help any? The problem's apparently > >> not at the end of the routine where we've been, er, focusing. > >> > >> Jay > >> > >> > >> _______________________________________________ > >> Rails-spinoffs mailing list > >> [email protected] > >> http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs > >> > >> > > _______________________________________________ > > Rails-spinoffs mailing list > > [email protected] > > http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs > > > > _______________________________________________ > Rails-spinoffs mailing list > [email protected] > http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs > _______________________________________________ Rails-spinoffs mailing list [email protected] http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs _______________________________________________ Rails-spinoffs mailing list [email protected] http://lists.rubyonrails.org/mailman/listinfo/rails-spinoffs
