On 16/08/2008, at 2:19 AM, Luis Lavena wrote:

On Fri, Aug 15, 2008 at 5:54 PM, Berger, Daniel <[EMAIL PROTECTED] > wrote:
-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Adam Salter
Sent: Friday, August 15, 2008 12:39 AM
To: Rake Development and Discussion
Subject: Re: [Rake-devel] ~/.rake file?

Dear all,
I have created a issue for this, with associated comments and patch:
http://onestepback.org/redmine/issues/show/13

It basically just needs:
a) Windows testing.

<snip>


<further snip>

Don't do this:

PLATFORM =~ /win32/

First, PLATFORM is deprecated instead of RUBY_PLATFORM. But, with the
advent of alternative implementations like Jruby and IronRuby,
RUBY_PLATFORM is no longer a wise approach. Jruby, for example, will
return 'java' for the RUBY_PLATFORM, even if you're on Windows.

Use rbconfig + host_os instead:

require 'rbconfig'

if Config::CONFIG['host_os'] =~ /mswin/I
...


Don't compare just to mswin either.

That bangs out not only MinGW (mingw) but also bccwin, which even has
no release in long time, there are some users interested in keeping it
running.


Why should I care about MinGW? Aren't we just trying to get Windows (ie non-Unix)?

-Adam
_______________________________________________
Rake-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/rake-devel

Reply via email to