On Nov 5, 2008, at 2:58 AM, Ittay Dror wrote:
This patch removes the use of Dir#[] when calculating excludes from
a FileList object.
Using Dir#[] scans the filesystem for matching files which can both
create a performance problem and be inaccurate, in case I want to
exclude a non existing patterns, or Dir.chdir was called since the
FileList was generated.
The patch instead uses File#fnmatch? to match the pattern to the
list of files. The patch also removes calculate_exclude_regexp and
instead does all work in #exclude?, the assumption being that it is
not normal to have many exclude patterns anyway nor that their
grouping into one regular expression improves performance greatly.
Sorry, I've gotten behind again. Sigh.
I've made a ticket for this (http://onestepback.org/redmine/issues/show/37
) and will consider it for post 0.8.4.
--
-- Jim Weirich
-- [EMAIL PROTECTED]
_______________________________________________
Rake-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/rake-devel
