So it caches the entire file?
Doesn’t it also have to examine and parse the backtrace to even determine the 
file to load?  Doing any of this on *every* task init bothers me – particularly 
when I’m creating thousands upon thousands of task objects.
Yeah, still a bad idea imo.

From: [email protected] 
[mailto:[email protected]] On Behalf Of Dave Thomas
Sent: Thursday, June 04, 2009 6:12 PM
To: Rake Development and Discussion
Subject: Re: [Rake-devel] Rake DSL Commands are no long in top level


On Thu, Jun 4, 2009 at 4:38 PM, Bennett, Patrick 
<[email protected]<mailto:[email protected]>> wrote:
I think the 'ruby comments as rake task comments' patch is a really bad idea.
I really don't like the idea of the task methods going back and reading the 
rakefile *every* time a task is defined to see if a comment line proceeds the 
task.
For complex rakefiles or for code that dynamically creates tasks (ie: for 
dependency trees) this seems like a real performance killer for little more 
than a 'cute' feature IMO.

It only reads once per file.


Dave
_______________________________________________
Rake-devel mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/rake-devel

Reply via email to