Chintana Wilamuna wrote:
Hi,
During the development of WSF/Perl, I got to know that Rampart expects
the certificate to be without the delimiters. Although this could
easily be done using which ever the scripting language, I think this
should be done in Rampart itself. Just like the newline removing
function oxs_util_get_newline_removed_string. I wrote a very simple
function to get rid of the delimiters if those are present.
+1 Iff ... "If those are present"
I would like to know whether there are any reasons not to do that
within Rampart before sending a patch.
There are no reasons. openssl_x509_get_cert_data() does exactly the same
thing. Basically the certificate is the content in between BEGIN and
END delimiters. In a PEM file the content are the base64 encoded DER
(=>Binary form). So Rampart/C expects everything is in base64 encoded
format.
But I think your patch targeting the "string" (buffer) form rather than
"file name" form. So "If present" remove the delimiters makes no harm.
Cheers,
Kau
Thanks in advance,
Bye,
-Chintana
--
http://blog.kaushalye.org/
http://wso2.org/
