On 2011-03-16, Marvin Humphrey wrote:

> On Tue, Mar 15, 2011 at 06:04:13AM +0100, Stefan Bodewig wrote:
>> I've seen you've already sold your soul to buildbot 8-)

> And it feels good!

Great.  In case it wasn't clear, I very much appreciate Gav encouraging
users to run RAT by making it dead easy via buildbot.

> I'm still willing to take a crack at this if it would be useful.

That would be good.  I can't say when I'll find the next bigger chunk of
coding time for RAT.

> I wonder, though -- is RAT intended for use outside the context of the
> ASF?

In theory it was, it started its live a Google Code.  I'm not sure
whether it is in practice.

>>> A couple different approaches are possible.

>>>     * Modify the interface for -e/--exclude
>>>     * Introduce a new command line flag.

>> Unless you manage to implement the first one in a way that it still
>> works the same for all old command line invocations (or all reasonable
>> uses) I'd prefer the second.  -E may be good.

> If we wanted to modify -e while attempting to preserve back compat, we could
> apply the filter twice: once against the file and once against the path.

[snipped analysis of edge cases]

> Thus I don't think it would be wise to modify -e/--exclude unless
> breaking back compat is acceptable.  Since it's not, the only option
> is to create another flag.

+1

Stefan

Reply via email to