On 26 November 2011 12:02, Hugo Hirsch <[email protected]> wrote:
> Hi *,
>
> I've proposed an automated code formatting via Jira
> (https://issues.apache.org/jira/browse/RAT-103) -
> that means with each mvn run the sources are formatted based on a
> default formatter (attached to the issue as well).
>
> Thus there are major changes when the plugin is enabled. Afterwards
> reformatting only applies to patches.
>
> The main goal of this is a cleaner readability of the code since some
> parts are formatted in C-style, others in Java-style, others in free

Is there a single Java style? or C style for that matter?

;-)

> style :-) I'd be happy to see a uniquely formatted code before the
> project leaves the incubator.
>
> Any objections/opinions?

Unless the code is very badly formatted, I'm not sure it's worth the
extra effort.
I'm still finding mangled (badly wrapped) comments in code that was
reformatted years ago.

However, I would recommend at least:
- removing all tabs
- ensuring consistent indentation (Java 4 spaces; XML 4 or 2)

I think these can be done with little or no adverse affect.

Also, once those are done, re-inspect the code and see if is still too diverse.

> Yours
> Hugo
>
>

Reply via email to