[ https://issues.apache.org/jira/browse/RAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb reopened RAT-109: ---------------------- There's a small window in the patch code which can potentially cause a failure, see https://issues.apache.org/jira/browse/JCI-67 for further details. The checks need to be the other way round, i.e. if(!parent.mkdirs() && !parent.exists()) { // or !isDirectory() as appropriate throw... } > Return value of mkdirs() is not checked and no error handling occurs > -------------------------------------------------------------------- > > Key: RAT-109 > URL: https://issues.apache.org/jira/browse/RAT-109 > Project: RAT > Issue Type: Bug > Affects Versions: 0.9 > Environment: Revision: 1208077 > Reporter: Hugo Hirsch > Fix For: 0.9 > > Attachments: RAT106errorPatch.diff, RAT109checkmkdirsReturnValue.patch > > > The code contains calls to mkdir() without checking its return value. > Patch attached for classes: > * apache-rat-plugin/src/main/java/org/apache/rat/mp/RatReportMojo.java > * apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java > * apache-rat-tasks/src/test/java/org/apache/rat/anttasks/ReportTest.java -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira