Hi Martin,

On Wed, 2007-11-28 at 19:54 +0100, Martin Egger wrote:
> here is a small patch to display the status of the Flash in EXIF data. It is a
> very quick and dirty check for tag 0x9209. For Canon CR2 files, the values are
> either 0x9 (flash fired) or 0x10 (no flash).

I'm not sure it's that relevant - but let's leave that for now (I have
been thinking about either a pop-up window when you click the exif-info
or a tooltip with extended information).

Are you sure it's as simple as that to read? According to
http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/EXIF.html it's
more complicated than so, to make matters worse 0x9 is "On" while 0x10
if "Off" - no info about whether it actually fired.

> As I am not a C programmer, you should probably review it the patch ;-)

I suggest the following:
- Test some more - auto flash, manual flash, built-in flash, external
flash etc.
- Change the type of RS_METADATA::flash to gboolean.
- Initialize RS_METADATA::flash in rs_metadata_new() to FALSE.
- Use a switch() to set the value of flash according to the 0x9209 tag.

> Have fun

I do!

/abrander



_______________________________________________
Rawstudio-dev mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev

Reply via email to