Hi Pi and Edouard, On Sat, 2008-10-18 at 16:02 +0200, Edouard Gomez wrote: > > Another fix is PIC compatible code generation which can be enabled with > > CFLAGS="-fPIC -fomit-frame-pointer". I won't compile because of asm > > includes > > in src/arch-x86.c which use EBX register. Actually one can use this > > register but > > have to save content of the register, do what you need, recover ebx and > > don't confess. > I prefer doing it this way.
I agree. > > It compiles and works well. I tried under Ubuntu - it works too. > > Maybe I am wrong or reinvent a wheel but I hope that attached patch > > would be useful. > > Current trunk segfaults so I took 1.1.1 version for a diff. > > I double checked that no other places were using ebx (either ebx or > the 32/64 bit helper REG_b). Your patch seems to fix the single case > ebx/REG_b is used w/o saving registers to the stack. > > Just in case it needed review, i'd say this should be merged as is. Thanks for the patch Pi, thanks for reviewing it Gomez, I applied the patch to trunk revision 2076. /abrander _______________________________________________ Rawstudio-dev mailing list [email protected] http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
