Rawstudio does not compile correctly with the -Werror=format-security
CFLAG for gcc. Can you please review this patch and include it if it's
correct? Thanks.
--- rawstudio-1.2/src/rs-metadata.c~ 2009-04-09 23:21:45.000000000 +0200
+++ rawstudio-1.2/src/rs-metadata.c 2009-05-06 20:25:38.000000000 +0200
@@ -137,11 +137,11 @@
if (metadata->make != MAKE_UNKNOWN)
xmlTextWriterWriteFormatElement(writer, BAD_CAST
"make", "%d", metadata->make);
if (metadata->make_ascii)
- xmlTextWriterWriteFormatElement(writer, BAD_CAST
"make_ascii", metadata->make_ascii);
+ xmlTextWriterWriteFormatElement(writer, BAD_CAST
"make_ascii","%s", metadata->make_ascii);
if (metadata->make_ascii)
- xmlTextWriterWriteFormatElement(writer, BAD_CAST
"model_ascii", metadata->model_ascii);
+ xmlTextWriterWriteFormatElement(writer, BAD_CAST
"model_ascii", "%s", metadata->model_ascii);
if (metadata->time_ascii)
- xmlTextWriterWriteFormatElement(writer, BAD_CAST
"time_ascii", metadata->time_ascii);
+ xmlTextWriterWriteFormatElement(writer, BAD_CAST
"time_ascii", "%s", metadata->time_ascii);
if (metadata->timestamp > -1)
xmlTextWriterWriteFormatElement(writer, BAD_CAST
"timestamp", "%d", metadata->timestamp);
/* Can we make orientation conditional? */
--
Frederik Himpe
_______________________________________________
Rawstudio-dev mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
