I am interested in helping with the automated test suite. Having dug around the code for a little while, I can't find any existing test cases. Can someone verify this? If there are existing tests, how are they run? Any other info about the existing test cases would be great!
Andy On Mon, May 3, 2010 at 6:00 AM, <[email protected]> wrote: > Send Rawstudio-dev mailing list submissions to > [email protected] > > To subscribe or unsubscribe via the World Wide Web, visit > http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev > or, via email, send a message with subject or body 'help' to > [email protected] > > You can reach the person managing the list at > [email protected] > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Rawstudio-dev digest..." > > > Today's Topics: > > 1. Re: How can I help? (Andrew Young) > 2. Re: Crash in rawstudio 1.2 when loading first photo in > transform_nocms8_3dnow (David Sharp) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Sun, 2 May 2010 23:09:42 -0400 > From: Andrew Young <[email protected]> > Subject: Re: [Rawstudio-dev] How can I help? > To: [email protected] > Message-ID: > <[email protected]> > Content-Type: text/plain; charset="iso-8859-1" > > Klaus, > > Just saw your reply. Great! I am excited to help. I'll take a closer look > through the list you sent this week and will probably pester you with > questions as I learn more. > > Andy > > On Sun, Apr 25, 2010 at 6:00 AM, <[email protected] > >wrote: > > > Send Rawstudio-dev mailing list submissions to > > [email protected] > > > > To subscribe or unsubscribe via the World Wide Web, visit > > http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev > > or, via email, send a message with subject or body 'help' to > > [email protected] > > > > You can reach the person managing the list at > > [email protected] > > > > When replying, please edit your Subject line so it is more specific > > than "Re: Contents of Rawstudio-dev digest..." > > > > > > Today's Topics: > > > > 1. Re: How can I help? (Klaus Post) > > > > > > ---------------------------------------------------------------------- > > > > Message: 1 > > Date: Sat, 24 Apr 2010 13:36:49 +0200 > > From: Klaus Post <[email protected]> > > Subject: Re: [Rawstudio-dev] How can I help? > > To: [email protected] > > Message-ID: > > <[email protected]> > > Content-Type: text/plain; charset=UTF-8 > > > > Hi Andy! > > > > > > Thanks for the kind words. Anders and I have been away on a holiday > > trip, so we have not had the possibility to write to you sooner. > > > > Currently we are preparing a beta of 2.0, so the main focus is testing > > and bug fixes. We are pretty much where we would like to be in terms > > of features and performance, but are mainly looking at finetuning > > minor stuff and making sure everything works. > > > > Right now the major things that could be interesting are: > > > > Automatic testing. > > > > * Unit test of file decoding > > * Improve current file test of decode support, metadata read, wb read, > > lens information, existing profile, possibly with output to a > > readable/parsable format (xml?) > > * Filters input/output. > > * Filter fuzz testing (changing input/parameters and check for results). > > * More tests. > > > > That would be a major upgrade of our QA test, and I think you would be > > more qualified for this than any of us to be honest. > > > > ---- > > States > > > > For the GUI part, we are mainly "missing" one feature that will not > > make it into v2.0, a change to "state" based editing, that makes it > > possible to change the mode you are in, by simply clicking an icon, so > > you don't always have left-click-to-set-wb mode. The right click menu > > is too well hidden away, and a lot of features are only available > > there. This will also be familiar for most from other Raw editing > > software. > > > > > > http://bugzilla.rawstudio.org/show_bug.cgi?id=287 > > > > ---- > > Output plugins > > > > Fairly straightforward, and will help users a lot. > > We have added most obvious potential export options to the bugtracker, > > such as Picasa, digiKam, Web album, PDF, ODF - you name it :) > > Copy image to clipboard is also a feature that would be very helpful, > > to paste images into OpenOffice or other apps. > > > > The existing output plugins should be a good starting point. > > > > > > So there are still lots of things that could be worked on. I would > > suggest that you can start by sending your things as patches to Anders > > Brander, and when things work out, you could get direct commit access. > > > > > > Regards, Klaus Post > > > > http://www.klauspost.com > > > > > > > > On Mon, Apr 19, 2010 at 21:38, Andrew Young <[email protected]> wrote: > > > Rawstudio Development Team, > > > > > > I just read the two most recent blog entries on rawstudio.org. I love > > the > > > technical detail about the software development. I've been using > > Rawstudio > > > occasionally for a couple years and am very excited about 2.0. Sounds > > like > > > there are a lot of great improvements going into it. I am also a senior > > > software engineer and have been looking for an open source project to > > join. > > > I love the technical challenge of something like Rawstudio and I love > > taking > > > pictures too! Seems like a great combination. My skill sets include: > > > architecture and object-oriented design, algorithms, parallel > > programming, > > > GUI, test-driven development. I don't have a ton of time to commit but > > I'm > > > interested in helping when I can. I am already running the bleeding > edge > > > version out of svn and have created a bugzilla account. Any tips of > where > > I > > > can start? Bug reporting and fixes? I've never contributed to an open > > source > > > project before so I am not familiar with the standard processes. > > > > > > Andy > > > > > > _______________________________________________ > > > Rawstudio-dev mailing list > > > [email protected] > > > http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev > > > > > > > > > > > > > > ------------------------------ > > > > _______________________________________________ > > Rawstudio-dev mailing list > > [email protected] > > http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev > > > > > > End of Rawstudio-dev Digest, Vol 44, Issue 4 > > ******************************************** > > > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: > http://rawstudio.org/pipermail/rawstudio-dev/attachments/20100502/494a4ecf/attachment.html > > ------------------------------ > > Message: 2 > Date: Mon, 3 May 2010 01:37:43 -0700 > From: David Sharp <[email protected]> > Subject: Re: [Rawstudio-dev] Crash in rawstudio 1.2 when loading first > photo in transform_nocms8_3dnow > To: [email protected] > Message-ID: > <[email protected]> > Content-Type: text/plain; charset=ISO-8859-1 > > I figured this out. This instruction moves 32 bits of %mm5 into "r": > "movd %%mm5, %1\n\t" > > But r, as well as g and b, are declared as 'glong', which is 64-bits > on x86_64. This means the high dword of those variables will not be > the intended value. Declaring them as 'gint' seems to do the trick. > Using a specifically 32-bit type would probably be better. > > Here's the obvious patch against the rawstudio-1.2 branch (sorry, > gmail will mangle it, but it's trivial to manually apply anyway). I > couldn't find a similar function in HEAD: > > >From 843a078f6f08d1839f08a92eaaea5a4e37187926 Mon Sep 17 00:00:00 2001 > From: David Sharp <[email protected]> > Date: Mon, 3 May 2010 00:37:08 -0700 > Subject: [PATCH] transform_nocms8_3dnow(): r,g,b should be 32-bits > > --- > src/rs-color-transform.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/src/rs-color-transform.c b/src/rs-color-transform.c > index a776dc5..1d9a184 100644 > --- a/src/rs-color-transform.c > +++ b/src/rs-color-transform.c > @@ -565,7 +565,7 @@ COLOR_TRANSFORM(transform_nocms8_3dnow) > { > gint destoffset; > gint col; > - register glong r=0,g=0,b=0; > + register gint r=0,g=0,b=0; > RS_DECLARE_ALIGNED(gfloat, mat, 4, 3, 8); > > if ((rct==NULL) || (width<1) || (height<1) || (in == NULL) || > (in_rowstride<8) || (out == NULL) || (out_rowstride<1)) > -- > 1.7.0.4 > > > On Sat, May 1, 2010 at 1:36 AM, David Sharp <[email protected]> wrote: > > -rawstudio-users, +rawstudio-dev > > > > any clues? need more info? > > > > On Thu, Feb 11, 2010 at 12:40 AM, David Sharp <[email protected]> > wrote: > >> The application starts, shows thumbnails across the top, but crashes > >> as soon as I open a photo. > >> > >> It segfaults in transform_nocms8_3dnow, which is odd because I would > >> think it would be using the sse version, since I have an athlon64 > >> which should support sse. > >> > >> Here's a backtrace: > >> > >> Program received signal SIGSEGV, Segmentation fault. > >> 0x000000000045f88b in transform_nocms8_3dnow () > >> Current language: ?auto > >> The current source language is "auto; currently asm". > >> (gdb) bt > >> #0 ?0x000000000045f88b in transform_nocms8_3dnow () > >> #1 ?0x0000000000461b2e in buffer () > >> #2 ?0x0000000000461d0a in redraw () > >> #3 ?0x0000000000463173 in rs_preview_widget_update () > >> #4 ?0x0000000000464688 in rs_preview_widget_set_photo () > >> #5 ?0x000000000041324c in rs_set_photo () > >> #6 ?0x000000000042020f in icon_activated () > >> #7 ?0x0000003cda20d12d in g_closure_invoke () from > /usr/lib/libgobject-2.0.so.0 > >> #8 ?0x0000003cda2222b2 in signal_emit_unlocked_R () from > >> /usr/lib/libgobject-2.0.so.0 > >> #9 ?0x0000003cda223807 in g_signal_emit_valist () from > >> /usr/lib/libgobject-2.0.so.0 > >> #10 0x0000003cda223cd3 in g_signal_emit () from > /usr/lib/libgobject-2.0.so.0 > >> #11 0x000000000045ed07 in selection_changed () > >> #12 0x0000003cda20d12d in g_closure_invoke () from > /usr/lib/libgobject-2.0.so.0 > >> #13 0x0000003cda2222b2 in signal_emit_unlocked_R () from > >> /usr/lib/libgobject-2.0.so.0 > >> #14 0x0000003cda223807 in g_signal_emit_valist () from > >> /usr/lib/libgobject-2.0.so.0 > >> #15 0x0000003cda223cd3 in g_signal_emit () from > /usr/lib/libgobject-2.0.so.0 > >> #16 0x00007ffff7afe870 in gtk_icon_view_button_press () from > >> /usr/lib/libgtk-x11-2.0.so.0 > >> #17 0x00007ffff7b22438 in _gtk_marshal_BOOLEAN__BOXED () from > >> /usr/lib/libgtk-x11-2.0.so.0 > >> #18 0x0000003cda20d12d in g_closure_invoke () from > /usr/lib/libgobject-2.0.so.0 > >> #19 0x0000003cda221fa6 in signal_emit_unlocked_R () from > >> /usr/lib/libgobject-2.0.so.0 > >> #20 0x0000003cda2236a0 in g_signal_emit_valist () from > >> /usr/lib/libgobject-2.0.so.0 > >> #21 0x0000003cda223cd3 in g_signal_emit () from > /usr/lib/libgobject-2.0.so.0 > >> #22 0x00007ffff7c213a6 in gtk_widget_event_internal () from > >> /usr/lib/libgtk-x11-2.0.so.0 > >> #23 0x00007ffff7b1b19b in gtk_propagate_event () from > >> /usr/lib/libgtk-x11-2.0.so.0 > >> #24 0x00007ffff7b1c22b in gtk_main_do_event () from > /usr/lib/libgtk-x11-2.0.so.0 > >> #25 0x00007ffff779e0fc in gdk_event_dispatch () from > >> /usr/lib/libgdk-x11-2.0.so.0 > >> #26 0x0000003cdae38e51 in g_main_context_dispatch () from > >> /usr/lib/libglib-2.0.so.0 > >> #27 0x0000003cdae3c3e8 in g_main_context_iterate () from > >> /usr/lib/libglib-2.0.so.0 > >> #28 0x0000003cdae3c8bd in g_main_loop_run () from > /usr/lib/libglib-2.0.so.0 > >> #29 0x00007ffff7b1c617 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 > >> #30 0x000000000041fe66 in gui_init () > >> #31 0x0000000000412a19 in main () > >> > >> > >> Here's some light debugging/disassembly work: > >> > >> ??? ??? ??? d[destoffset++] = rct->table8[r]; > >> ??? ??? ??? d[destoffset++] = rct->table8[g]; > >> ??? ??? ??? d[destoffset++] = rct->table8[b]; > >> > >> 0x000000000045f865 <transform_nocms8_3dnow+485>:??? mov > >> 0x148(%rdi),%rax?????? %rax = rct->table8 > >> 0x000000000045f86c <transform_nocms8_3dnow+492>:??? movzbl > (%rax,%rbx,1),%eax > >> 0x000000000045f870 <transform_nocms8_3dnow+496>:??? mov??? > %al,(%r9,%rdx,1) > >> 0x000000000045f874 <transform_nocms8_3dnow+500>:??? mov??? > 0x148(%rdi),%rax > >> 0x000000000045f87b <transform_nocms8_3dnow+507>:??? movzbl > (%rax,%rsi,1),%eax > >> 0x000000000045f87f <transform_nocms8_3dnow+511>:??? mov??? > %al,0x1(%r9,%rdx,1) > >> 0x000000000045f884 <transform_nocms8_3dnow+516>:??? mov > >> 0x148(%rdi),%rax?????? %rax = rct->table8 > >> 0x000000000045f88b <transform_nocms8_3dnow+523>:??? movzbl > >> (%rax,%r11,1),%eax???? %eax = *(%rax+b) ? ? *** crash *** > >> 0x000000000045f890 <transform_nocms8_3dnow+528>:??? mov > >> %al,0x2(%r9,%rdx,1)??? d[destoffset+2] = %al > >> 0x000000000045f895 <transform_nocms8_3dnow+533>:??? add??? $0x3,%rdx > >> ?????????? destoffset += 3 > >> > >> r => %rbx?????????? = 0 > >> g => %rsi?????????? = 0 > >> b => %r11?????????? = 0x52f9000052f9??? 91229400355577 > >> destoffset => %rdx? = 0 > >> d => %r9??????????? = 0xc89f80 > >> mat => %rbp ? ? ? ? = 0x7fffffffc920 > >> *mat: > >> (gdb) x/12wf 0x7fffffffc920 > >> 0x7fffffffc920: 1.2081722 ? ? ? -0.15823926 ? ? -0.0499329716 ? 0 > >> 0x7fffffffc930: 0.0230940226 ? ?1.23610961 ? ? ?-0.259203643 ? ?0 > >> 0x7fffffffc940: 0.0542779602 ? ?-0.188402981 ? ?1.13412499 ? ? ?0 > >> (gdb) x/12wx 0x7fffffffc920 > >> 0x7fffffffc920: 0x3f9aa563 ? ? ?0xbe220979 ? ? ?0xbd4c8684 ? ? > ?0x00000000 > >> 0x7fffffffc930: 0x3cbd2fad ? ? ?0x3f9e38d7 ? ? ?0xbe84b657 ? ? > ?0x00000000 > >> 0x7fffffffc940: 0x3d5e5291 ? ? ?0xbe40ecb6 ? ? ?0x3f912b02 ? ? > ?0x00000000 > >> > >> > >> As you can see, b is waaay off. ?I think 0x529f is a more reasonable > >> value (the lower 32 bits)? > >> > > > > > > ------------------------------ > > _______________________________________________ > Rawstudio-dev mailing list > [email protected] > http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev > > > End of Rawstudio-dev Digest, Vol 45, Issue 2 > ******************************************** >
_______________________________________________ Rawstudio-dev mailing list [email protected] http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev
