On 10-07-05 3:06 PM, Edouard Gomez wrote:
> Big endian support kind of broke the nef decoding on my box.
>
> I narrowed it down to the fact the NefDecoder constructor was
> passed a copy instead of a ref. This caused a ByteStream instance
> to be used in all cases, whatever the endianness, because the
> copy constructor is called implicitly during argument passing.
[...]
> -  void DecompressNikon(ByteStream meta, uint32 w, uint32 h, uint32 bitsPS, 
> uint32 offset, uint32 size);
> +  void DecompressNikon(ByteStream&  meta, uint32 w, uint32 h, uint32 bitsPS, 
> uint32 offset, uint32 size);

May I suggest to use a const reference here?
Just to ensure the ByteStream does not get modified.


Hub

_______________________________________________
Rawstudio-dev mailing list
[email protected]
http://rawstudio.org/cgi-bin/mailman/listinfo/rawstudio-dev

Reply via email to