On Fri, 26 Jan 2007, Marc Dyksterhouse wrote: > http://www.visiwave.com/download/rdiff_backup/rpath.py.patch
can you provide more information on why this is necessary? i'm assuming it's because cygwin/windows can't do an fsync in some situation... would it be possible to put another try/except around the os.fsync to catch that case instead of just disabling the fsync entirely? i don't think i want to commit this patch as is... unless that fsync really isn't necessary. > http://www.visiwave.com/download/rdiff_backup/Security.py.patch committed to cvs HEAD > http://www.visiwave.com/download/rdiff_backup/FilenameMapping.py.patch committed to cvs HEAD > http://www.visiwave.com/download/rdiff_backup/fs_abilities.py.patch hmm i'm committing this anyhow because i didn't notice the previous patch depends on it... next time send them in order please :) but -- can you expand on this chunk: - else: return "^a-z0-9_ -." # quote everything but basic chars + else: return "^a-z0-9_ .-" # quote everything but basic chars if self.dest_fsa.extended_filenames: return "" # Don't quote anything - else: return "^A-Za-z0-9_ -." + else: return "^A-Za-z0-9_ .-" " -." is a valid range... so this change will start escaping those things except for space dot dash... this was intentional? oh and... i tested none of this. i encourage folks to grab the cvs head and report back if it's broken or not. -dean _______________________________________________ rdiff-backup-users mailing list at [email protected] http://lists.nongnu.org/mailman/listinfo/rdiff-backup-users Wiki URL: http://rdiff-backup.solutionsfirst.com.au/index.php/RdiffBackupWiki
