Yes, "GetLastItemText" is more explicit, and hence better. And I guess there is no harm in having it in the super class (and by extension, in SmilesMolSupplier or TDTMolSupplier).
- Jean-Paul Ebejer Early Stage Researcher On 18 January 2012 06:09, Greg Landrum <[email protected]> wrote: > Dear Jean-Paul > > On Tue, Jan 17, 2012 at 5:41 PM, JP <[email protected]> wrote: >> >> I think a GetItemText() (without the index) - just getting the text of >> the molecule we are on is a needed and useful API addition to this >> class. > > I agree that it would be useful to get the text that corresponds to > the last entry read. The method name is probably going to be > GetLastItemText() and I will add it to the generic suppliers interface > (so that it works for the normal SDMolSupplier too). > > Sound ok? > -greg ------------------------------------------------------------------------------ Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d _______________________________________________ Rdkit-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/rdkit-discuss
