On Wed, Jul 11, 2012 at 9:34 AM, David A. Wheeler <dwhee...@dwheeler.com> wrote:
> Alan Manuel Gloria
>> Have a new bundle - this is dependent on the earlier bundle.
>
> Excellent!  I've accepted and pushed all the commits.  Thanks.
>
>>     Make sweet-filter script more resistant to differences in Guile version.
>
> Thanks.  It looks odd, but I don't know of a better way to do it.
>
> BTW, some test cases fail (your patches didn't cause the failure, they didn't 
> work before).  Currently "tests/all-tests" reports this:
> Correct answers:  54 test errors: 3
> The problem is that abbreviations (quote) followed by space and "group" do 
> not play well together.  I haven't tracked down the bug, since it all may be 
> moot if change GROUP/SPLICE/etc.

Hmm.

Arguably the problem is that GROUP was never deeply specced.... The
original SRFI just says:

> The special non-terminal symbol sexpr expands to any valid S-expression, and 
> the special terminal symbol GROUP expands to
> the word "group" in the input stream. The GROUP symbol is used to allow lists 
> whose first element is also a list. It is needed as
> the indentation of an empty line is not accounted for.

Egil went on the list and then explained GROUP more as:

> Group does not add () around an expression, this is *only ever* done by 
> indentation. What group means is an special ("empty")
> symbol that is removed if found first in an expression

And indeed, this is compatible with what the SRFI spec says - "GROUP
is used to ***allow*** lists whose first element is also a list", not
like "GROUP ***means*** make the first line a sublist of the current
list".

However, looking at how the code *actually works*, it seems to be more
like "GROUP is only removed if it is exactly at the start of the
line", meaning that ' et al *disable* how GROUP works.

Possibly, instead of handling quote inside readitem, it should be
handled in readblock, which seems to be approximately a combination of
the expr and head productions in the SRFI-49 spec.

Sincerely,
AmkG

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Readable-discuss mailing list
Readable-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/readable-discuss

Reply via email to