On Friday 26 May 2006 17:33, Paul Moore wrote: > For the curious this is the change between the lspp.29 patch and the one > attached to this mail, from the include/net/netlabel.h file:
Thanks for the patch update. lspp.31 is building, but I can confirm its working. But looking at the patch...I have some questions. (Normally, I would put comments inline with the patch, but this patch is too big for that.) 1) How is errors sent back to user space when a metlink command does not work? 2) Are there any capabilities checks needed to issue commands to the subsystem? Or can any user send commands? 3) How carefully is the data from user space being checked before using it? Usually it needs to be carefully checked and then used. 4) Do you need to use NLMSG_ALIGN macro when checking sizes of things? 5) Should you be using NETLINK_CB(skb).pid instead of nl_hdr->nlmsg_pid? Also, is there a user space tool that you are testing the netlink interface with ? -Steve -- redhat-lspp mailing list [email protected] https://www.redhat.com/mailman/listinfo/redhat-lspp
