Barry,

I respond to your feedback embedded below.  I saw Martin's reply that I 
reference for section 3 below.  I will publish 
draft-ietf-regext-unhandled-namespaces-07 once these items are agreed to.  Let 
me know if you agree with the proposed updates below or if you have any 
additional proposed changes.    

Thanks,

-- 
 
JG



James Gould
Fellow Engineer
jgo...@verisign.com 
<applewebdata://13890C55-AAE8-4BF3-A6CE-B4BA42740803/jgo...@verisign.com>

703-948-3271
12061 Bluemont Way
Reston, VA 20190

Verisign.com <http://verisigninc.com/>

On 1/22/21, 2:23 PM, "Barry Leiba" <barryle...@computer.org> wrote:

    Thanks for the publication request for this document; here's my AD
    review.  None of this is a big thing, just some easy tweaks.  It will
    need a revised I-D, though, so I'll set the substate accordingly.

    The Abstract goes into more detail than the Abstract needs to or
    should.  The Introduction correctly explains the details, but the
    Abstract shouldn’t.  I suggest trimming the Abstract thus (but please
    do use your judgment on this):

    NEW
       The Extensible Provisioning Protocol (EPP), as defined in RFC 5730,
       includes a method for the client and server to determine the objects
       to be managed during a session and the object extensions to be used
       during a session.  The services are identified using namespace URIs,
       and an “unhandled namespace” is one that is associated with a service
       not supported by the client in question.  This document defines an
       operational practice that enables the server to return information
       associated with unhandled namespace URIs that is compliant with the
       negotiated services defined in RFC 5730.
    END

JG - I took your proposal with one tweak in removing "in question" from "client 
in question". 

    — Section 1.1 —

    Please use the new BCP 14 boilerplate and add a normative reference to RFC 
8174.

       Indentation and white space in examples are provided only to
       illustrate element relationships and are not a REQUIRED feature of
       this protocol.

    That’s not a BCP 14 usage of “required”, and should be in lower case.

JG - Done

    — Section 3 —

           XML processing of the <value> element is
           disabled in [RFC5730],

    Where and how is this stated in 5730?  I can’t find anything, but
    perhaps I just don’t know where to look.  It would be good to add a
    section number to the citation.

JG - This is not stated in the text of RFC5730, but is based on the XML schema 
use of the processContents="skip" attribute of the "errValueType" type in 
section 4.1 "Base Schema".  How about revising this to read "XML processing of 
the <value> element is disabled by the XML schema in [RFC5730]".  Martin 
provided more context around the use of the <value> element, but I believe that 
we can provide clarity around the statement with the reference to the XML 
schema.  Does adding this help clarify the statement?  

    — Section 8.2 —

    Please change the Registrant Name to “IETF” (you may leave the email
    address as it is), as that’s how the IESG prefers to designate it (the
    IETF

JG - Done

    — Section 10 —

    Nit: make it “This document does not provide…”

JG - Done

    That aside, I would be surprised if we don’t get some pushback about
    this section, so maybe we should think about it a bit more.  I accept
    that there are likely no security issues raised by this operational
    practice, but it would be good to address that more directly.  This is
    proposing that a server return information to a client that indicates
    that the server believes a particular service is not supported by the
    client.  You should call that out, and consider whether that could
    expose anything that could be used by an attacker — or that could be
    misused to create an attack.  Or, could an attacker do something
    related to this practice that would allow it to disrupt some
    legitimate communication?

    The answer to all of that might be “no”, but it would be good to… as
    we used to say in school, show your work.

JG - Yes, the quick answer is that I don't see the server using this as a 
source for an attack, but we can add a consideration to help mitigate it.  I 
can add the sentence "Since the unhandled namespace context is XML that is not 
processed in the first pass by the XML parser, the client SHOULD consider 
validating the XML when the content is processed to protect against the 
inclusion of malicious content."  The content is not processed by a client that 
doesn't support the service, where the <extValue> element provides a signal of 
the lack of client support along with the XML content that is initially 
unprocessed.  If the client does decide to process the XML content 
systematically, the additional sentence can provide guidance to not open up a 
security hole.  Do you believe this will help?  Do you have any additional 
recommended text?      

    -- 
    Barry

_______________________________________________
regext mailing list
regext@ietf.org
https://www.ietf.org/mailman/listinfo/regext

Reply via email to