On Sun, 27 Aug 2006 04:34:26 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> The patch below is so-called reiser4 LZO compression plugin as extracted > from 2.6.18-rc4-mm3. > > I think it is an unauditable piece of shit and thus should not enter > mainline. Like lib/inflate.c (and this new code should arguably be in lib/). The problem is that if we clean this up, we've diverged very much from the upstream implementation. So taking in fixes and features from upstream becomes harder and more error-prone. I'd suspect that the maturity of these utilities is such that we could afford to turn them into kernel code in the expectation that any future changes will be small. But it's not a completely simple call. (iirc the inflate code had a buffer overrun a while back, which was found and fixed in the upstream version).
