----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102180/#review5318 -----------------------------------------------------------
src/webview.cpp <http://git.reviewboard.kde.org/r/102180/#comment4808> I fear that the default engine could be null, leading to a crash in the following line. Better check it :) - Andrea On Aug. 2, 2011, 3:06 p.m., Johannes Tröscher wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102180/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2011, 3:06 p.m.) > > > Review request for rekonq. > > > Summary > ------- > > action to search with default searchEnine in marked text's context menu > > > Diffs > ----- > > src/webview.cpp 1490c9b > > Diff: http://git.reviewboard.kde.org/r/102180/diff > > > Testing > ------- > > compiles and works > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/102180/s/215/ > > > Thanks, > > Johannes > >
_______________________________________________ rekonq mailing list [email protected] https://mail.kde.org/mailman/listinfo/rekonq
