> On March 30, 2013, 5:25 p.m., Andrea Diamantini wrote: > > src/history/historymanager.h, line 97 > > <http://git.reviewboard.kde.org/r/109613/diff/1/?file=120601#file120601line97> > > > > why this? Are you aware this will completely break previous history? > > mayank jha wrote: > I was trying to save each session separately irrespective of the history. > is that okay? > > Andrea Diamantini wrote: > well... no and no! Please, read the code you are going to modify.
oops! history has nothing to do with this! my bad! - mayank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109613/#review30156 ----------------------------------------------------------- On March 20, 2013, 4:54 p.m., mayank jha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109613/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 4:54 p.m.) > > > Review request for rekonq. > > > Description > ------- > > A patch which allows you to save and later reload your important browsing > sessions! > > > Diffs > ----- > > src/history/historymanager.h a618c67 > src/history/historymanager.cpp 2fab9cf > src/sessionmanager.h 6d6bef2 > src/sessionmanager.cpp 8c78172 > src/webwindow/rekonqui.rc 90c5c19 > src/webwindow/webwindow.h b2e0f5a > src/webwindow/webwindow.cpp 1225fb0 > > Diff: http://git.reviewboard.kde.org/r/109613/diff/ > > > Testing > ------- > > works fine! > > > Thanks, > > mayank jha > >
_______________________________________________ rekonq mailing list rekonq@kde.org https://mail.kde.org/mailman/listinfo/rekonq