Ok, I'll make the commits then post again to show how it was done. Regards,
Edward On 19 June 2013 16:00, Troels Emtekær Linnet <[email protected]> wrote: > Hi Edward. > > I am so confused now, what you want. > > Can you fix it from here? > > I will try next time to follow, but this is killing me. > > Best > Troels > > Troels Emtekær Linnet > > > 2013/6/19 Edward d'Auvergne <[email protected]> >> >> Hi, >> >> Don't worry about all the bouncing back and forth at the start. This >> process will become quicker with time as I have less to comment on. >> It's just part of the initial learning curve for building up enough >> knowledge as to how a large software project operates, to then become >> accepted as a developer with full commit access. Learning about the >> commit process - what should constitute a commit and how to write the >> commit message - is quite important for this. >> >> Regards, >> >> Edward >> >> >> >> On 19 June 2013 15:43, Edward d'Auvergne <[email protected]> wrote: >> > Hi, >> > >> > The fix for the pipe_control.palmer module is not necessary. This was >> > fixed in trunk - where I made the mistake - and is now merged into the >> > relax_disp branch. I was just a bit too slow for you ;) Also, where >> > you make changes such as: >> > >> > - file.write(" if \"PNG\" in types:\n") >> > + file.write(" if (\"PNG\" in types or \".PNG\" in types or >> > \"png\" in types or \".png\" in types):\n") >> > >> > this should be in separate patch as it does something different. >> > Ideally the switch to optparse and the chmod() call should also be >> > separate as they are different, and they apply to different parts of >> > the codebase. >> > >> > Cheers, >> > >> > Edward >> > >> > >> > >> > >> > On 19 June 2013 15:19, Troels E. Linnet >> > <[email protected]> wrote: >> >> Follow-up Comment #8, bug #20916 (project relax): >> >> >> >> Fix for bug #20916 (https://gna.org/bugs/?20916) Suggestion for python >> >> script >> >> for PNG/EPS/SVG conversion of grace files >> >> >> >> Optimized according to >> >> (http://thread.gmane.org/gmane.science.nmr.relax.devel/3953) >> >> >> >> Also a small fix to the pipe_control/palmer.py >> >> since there where a wrong call to the import function. >> >> >> >> Patch6 added >> >> >> >> (file #18119) >> >> _______________________________________________________ >> >> >> >> Additional Item Attachment: >> >> >> >> File name: patch6 Size:8 KB >> >> >> >> >> >> _______________________________________________________ >> >> >> >> Reply to this item at: >> >> >> >> <http://gna.org/bugs/?20916> >> >> >> >> _______________________________________________ >> >> Message sent via/by Gna! >> >> http://gna.org/ >> >> >> >> >> >> _______________________________________________ >> >> relax (http://www.nmr-relax.com) >> >> >> >> This is the relax-devel mailing list >> >> [email protected] >> >> >> >> To unsubscribe from this list, get a password >> >> reminder, or change your subscription options, >> >> visit the list information page at >> >> https://mail.gna.org/listinfo/relax-devel > > _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
