Hi,

For the 0004* patch, the new target function, this is almost perfect.
The only problem is the docstring having '..' at the end.  This
actually affects the API documentation compilation in strange ways.

Regards,

Edward


On 18 August 2013 16:14, Edward d'Auvergne <[email protected]> wrote:
> Hi,
>
> For the 0003* patch, the addition of the lib.dispersion.tsmfk01
> module, which file was this copied from?  It is clearly copied.  For
> history preservation, we should perform this action differently.  As
> you are using git, we will need to do the following:
>
> 1)  You make a request to copy file x to file y (with an appropriate
> commit message).
> 2)  I run 'svn cp x y' to duplicate the file, and commit the change.
> 3)  You then modify the duplicated file to suite as a second commit.
>
> When using subversion, this is easier as you can copy and modify in
> one go.  Note that this is essential and is how you must duplicate
> files in the future, especially if you have commit access.
>
> Regards,
>
> Edward
>
>
> On 18 August 2013 16:06, Edward d'Auvergne <[email protected]> wrote:
>> Hi Troels,
>>
>> I've applied the 0001* patch, but am stuck at the 0002* patch.  Your
>> code editor is removing trailing whitespace characters again.  But
>> this is fatal in the case of the equations in the relax_disp user
>> function docstrings.  In addition, could you explain what the R2bj
>> parameter is?  And for consistency the descriptions require double
>> spaces after a period.
>>
>> Regards,
>>
>> Edward
>>
>>
>> On 17 August 2013 21:47, Troels E. Linnet
>> <[email protected]> wrote:
>>> Follow-up Comment #2, sr #3071 (project relax):
>>>
>>> Step 1-4 for the implementation of Tollinger/Kay dispersion model (2001).
>>>
>>> Following the guide at:
>>> http://wiki.nmr-relax.com/Tutorial_for_adding_relaxation_dispersion_models_to_relax
>>>
>>> Until comments on pathches, the following pathces will concern the
>>> documentaion in:
>>> docs/latex
>>> bibliography.bib
>>> dispersion.tex
>>>
>>> (file #18695)
>>>     _______________________________________________________
>>>
>>> Additional Item Attachment:
>>>
>>> File name: TK.patch.tar.gz                Size:5 KB
>>>
>>>
>>>     _______________________________________________________
>>>
>>> Reply to this item at:
>>>
>>>   <http://gna.org/support/?3071>
>>>
>>> _______________________________________________
>>>   Message sent via/by Gna!
>>>   http://gna.org/
>>>
>>>
>>> _______________________________________________
>>> relax (http://www.nmr-relax.com)
>>>
>>> This is the relax-devel mailing list
>>> [email protected]
>>>
>>> To unsubscribe from this list, get a password
>>> reminder, or change your subscription options,
>>> visit the list information page at
>>> https://mail.gna.org/listinfo/relax-devel

_______________________________________________
relax (http://www.nmr-relax.com)

This is the relax-devel mailing list
[email protected]

To unsubscribe from this list, get a password
reminder, or change your subscription options,
visit the list information page at
https://mail.gna.org/listinfo/relax-devel

Reply via email to