Hi, Of course, this is a useful feature. I would recommend implementing this for the trunk though, as this is not specific to the relaxation dispersion branch. I'm wondering if we should create a short lived branch for this, just to keep the trunk functional during the development/fixing. Actually, that might be best. I have now created the 'value_write_fixes' branch for you to work on. You should familiarise yourself with branching and branch management in an svn repository - the branches section of the development chapter of the relax manual would be useful for this.
For the test I would recommend loading a file such as test_suite/shared_data/model_free/OMP/final_results_trunc_1.3_v2.bz2. These are model-free results but, if the value.write user function is fixed for this, it will be fixed for the dispersion analysis too. You could then use: data_list = ['select', 'model', 'params', 's2', 's2f', 's2s', 'te', 'tf', 'ts', 'Rex'] self.interpreter.value.write(param=data_list, file=self.tmpfile, dir=None, force=True) This should test out all different types - booleans, strings, lists, and floats. It should be quite comprehensive, and it should almost mimic the old relax state files (see test_suite/shared_data/model_free/OMP/final_results_trunc_1.2.bz2). Looking at the value.write backend more closely, I can see that many, many features have been lost. It is really a pity there was no system test written for it!! For example the headings are now 'value' and 'error' for the parameter. This needs to be changed as there is no error for certain data, and it would make little sense to have 10 columns with the title 'value'! Other useful features would be to have the 'sim_index' argument added, so that data for individual simulations could be output: self.interpreter.value.write(param=data_list, sim_index=1, file=self.tmpfile, dir=None, force=True) Fortunately the bc argument is still there, though I don't know how functional it is. That would require a separate system test as the OMP model-free results file contains no back-calculated data. The value.write user function used to have the flexibility of the value.set function. However the test suite only checks value.set. So value.set remains highly flexible while value.write has become a rigid, inflexible mess. Regards, Edward On 11 September 2013 09:08, Troels E. Linnet <[email protected]> wrote: > Follow-up Comment #3, sr #3078 (project relax): > > Hi Edward. Could this system test be implemented. > > It will help solve the bug: > ------- > It seems value.write does not accept list of model parameters. > > self.interpreter.value.write(param=['model','kex'], file=self.tmpfile, > dir=None, force=True) > > It expects a string as input. > > Ref: > http://article.gmane.org/gmane.science.nmr.relax.devel/4605 > > > > _______________________________________________________ > > Reply to this item at: > > <http://gna.org/support/?3078> > > _______________________________________________ > Message sent via/by Gna! > http://gna.org/ > > > _______________________________________________ > relax (http://www.nmr-relax.com) > > This is the relax-devel mailing list > [email protected] > > To unsubscribe from this list, get a password > reminder, or change your subscription options, > visit the list information page at > https://mail.gna.org/listinfo/relax-devel _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
