Hi Troels, This looks good! It should now ensure that this works permanently. Just a formatting hint though, you need to add blank lines above the comments, and have two blank lines before the test_hansen_trunc_data() method (see http://www.nmr-relax.com/manual/Whitespace.html). This is for easier readability. Also the last comment, apart from the period, could explain what you are testing and why it is 'Z_A0'. This is to aid a future developer understand why that is there, otherwise they might think that it is a mistake and delete those lines of code. The comment is to explain your intent for the next person who comes along.
Cheers, Edward On 6 December 2013 07:24, <[email protected]> wrote: > Author: tlinnet > Date: Fri Dec 6 07:24:15 2013 > New Revision: 21802 > > URL: http://svn.gna.org/viewcvs/relax?rev=21802&view=rev > Log: > Updated the gui-test to check for first ID in list. > > Fix for bug #21076, (https://gna.org/bugs/?21076) - When loading a > multi-spectra NMRPipe seriesTab file through the GUI, several Error messages > occur. > > Modified: > trunk/test_suite/gui_tests/relax_disp.py > > Modified: trunk/test_suite/gui_tests/relax_disp.py > URL: > http://svn.gna.org/viewcvs/relax/trunk/test_suite/gui_tests/relax_disp.py?rev=21802&r1=21801&r2=21802&view=diff > ============================================================================== > --- trunk/test_suite/gui_tests/relax_disp.py (original) > +++ trunk/test_suite/gui_tests/relax_disp.py Fri Dec 6 07:24:15 2013 > @@ -178,17 +178,24 @@ > analysis.peak_wizard_launch(None) > wizard = analysis.peak_wizard > > - # The spectrum. > + # The spectrum, use Keyword auto. > page = wizard.get_page(wizard.page_indices['read']) > > page.uf_args['file'].SetValue(str_to_gui("%sfolded_sparky_corr_final_max_standard_trunc.ser" > % data_path)) > page.uf_args['spectrum_id'].SetValue(['auto']) > wizard._go_next(None) > > - # The error type. > + # The error type window. > page = wizard.get_page(wizard.page_indices['err_type']) > page.selection = 'rmsd' > wizard._go_next(None) > > + # Get ID from RMSD window. > + page = wizard.get_page(wizard.page_indices['rmsd']) > + # Flush all wx events (to allow the spectrum list GUI element to > populate all its rows). > + wx.Yield() > + # Get the ID > + cur_id = page.uf_args['spectrum_id'].GetValue() > + self.assertEqual(cur_id, 'Z_A0') > > def test_hansen_trunc_data(self): > """Test the GUI analysis with Flemming Hansen's CPMG data truncated > to residues 70 and 71.""" > > > _______________________________________________ > relax (http://www.nmr-relax.com) > > This is the relax-commits mailing list > [email protected] > > To unsubscribe from this list, get a password > reminder, or change your subscription options, > visit the list information page at > https://mail.gna.org/listinfo/relax-commits _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
