Oh, you should also check the unit tests! I see 2 failures in the branch. Cheers,
Edward On 31 July 2014 17:44, Edward d'Auvergne <[email protected]> wrote: > One more point: > > - There is the line commented out > 'writing_vars.append(['disp_w_eff',("Experiment_name", > "Field_strength_(MHz)", "Effective_field_(rad_s-1))", > "R2eff_(measured)", "R2eff_(back_calc)", "R2eff_errors")])'. Either > activate it, delete it, or add a FIXME comment so that other > developers know what this is about. > > This is just a wish, and it can happen in the trunk. It would be good > if you could reproduce the figure 2 plot of Kjaergaard et al., 2013 > that you mention in https://gna.org/support/?3124, dump this into a PS > file, convert to EPS, and then include it in the manual with a short > description of how you created it. That way your new feature will be > far more discoverable for relax users. > > Cheers, > > Edward > > > > On 31 July 2014 17:36, Edward d'Auvergne <[email protected]> wrote: >> Hi, >> >> Just a few small things to polish off: >> >> - Expand the 'ex.' in the user function documentation to 'example'. >> The text should be formal. >> - Merge the trunk changes into the branch. >> >> I'll look at the code a bit more. >> >> Cheers, >> >> Edward >> >> >> >> On 31 July 2014 17:27, Troels E. Linnet >> <[email protected]> wrote: >>> Update of sr #3124 (project relax): >>> >>> Category: None => Feature request >>> Status: Postponed => Done >>> Open/Closed: Open => Closed >>> >>> _______________________________________________________ >>> >>> Follow-up Comment #132: >>> >>> This is now complete, and I ask for merge into relax trunk. >>> >>> _______________________________________________________ >>> >>> Reply to this item at: >>> >>> <http://gna.org/support/?3124> >>> >>> _______________________________________________ >>> Message sent via/by Gna! >>> http://gna.org/ >>> >>> >>> _______________________________________________ >>> relax (http://www.nmr-relax.com) >>> >>> This is the relax-devel mailing list >>> [email protected] >>> >>> To unsubscribe from this list, get a password >>> reminder, or change your subscription options, >>> visit the list information page at >>> https://mail.gna.org/listinfo/relax-devel _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
