Hi Edward. I reverted the change later, and fixed the bug.
Best Troels 2014-08-19 10:42 GMT+02:00 Edward d'Auvergne <[email protected]>: > :( Could a second mini-test be created by test duplication whereby > you do trigger this bug? This change removes coverage of the problem > from the test suite, which is unfortunate. The more code path > coverage, the better. Especially if that code path was once buggy or > non-functional as it might revert to a buggy or non-functional state > in the future, and we will only know about it when a user complains. > > Cheers, > > Edward > > On 14 August 2014 11:13, <[email protected]> wrote: >> Author: tlinnet >> Date: Thu Aug 14 11:13:30 2014 >> New Revision: 25022 >> >> URL: http://svn.gna.org/viewcvs/relax?rev=25022&view=rev >> Log: >> Removed triggering an error in test_r1rho_kjaergaard_missing_r1. >> >> There is a bug fetching the standard value of parameter 'r1_fit'. >> >> Modified: >> trunk/test_suite/system_tests/relax_disp.py >> >> Modified: trunk/test_suite/system_tests/relax_disp.py >> URL: >> http://svn.gna.org/viewcvs/relax/trunk/test_suite/system_tests/relax_disp.py?rev=25022&r1=25021&r2=25022&view=diff >> ============================================================================== >> --- trunk/test_suite/system_tests/relax_disp.py (original) >> +++ trunk/test_suite/system_tests/relax_disp.py Thu Aug 14 11:13:30 2014 >> @@ -5134,7 +5134,7 @@ >> MODELS = [MODEL_R2EFF, MODEL_NOREX_R1RHO_FIT_R1, >> MODEL_DPL94_FIT_R1, MODEL_TP02_FIT_R1, MODEL_TAP03_FIT_R1, >> MODEL_MP05_FIT_R1, MODEL_NS_R1RHO_2SITE_FIT_R1] >> >> # The grid search size (the number of increments per dimension). >> - GRID_INC = None >> + GRID_INC = 10 >> >> # The number of Monte Carlo simulations to be used for error >> analysis at the end of the analysis. >> MC_NUM = 3 >> >> >> _______________________________________________ >> relax (http://www.nmr-relax.com) >> >> This is the relax-commits mailing list >> [email protected] >> >> To unsubscribe from this list, get a password >> reminder, or change your subscription options, >> visit the list information page at >> https://mail.gna.org/listinfo/relax-commits > > _______________________________________________ > relax (http://www.nmr-relax.com) > > This is the relax-devel mailing list > [email protected] > > To unsubscribe from this list, get a password > reminder, or change your subscription options, > visit the list information page at > https://mail.gna.org/listinfo/relax-devel _______________________________________________ relax (http://www.nmr-relax.com) This is the relax-devel mailing list [email protected] To unsubscribe from this list, get a password reminder, or change your subscription options, visit the list information page at https://mail.gna.org/listinfo/relax-devel
