On Mon, 2012-03-26 at 08:07 -0400, Matthias Clasen wrote: > On Mon, Mar 26, 2012 at 6:45 AM, Florian Müllner <fmuell...@gnome.org> wrote: > > There is a problem with the new shell keyring dialogs, as demonstrated in > > this[0] video. The proper fix in bug 672543[1] is small but intrusive, so > > for the 3.4 release, I am proposing a safe workaround instead. It consists > > of giving checkbox labels a fixed height of two lines of text - as the > > widget is only used in keyring dialogs, no other UI is affected. A height of > > two lines should work correctly for most locales - for translations that are > > significantly shorter than English, there'll be some additional whitespace, > > for translations that are significantly longer (as far as I can tell, only > > Spanish is affected (yeah, German translation is missing ;-)), the last > > words will be cut off (we might consider using a height of three lines > > instead to only ever err on the safe side). > > > > The change does not affect either documentation or translations. > > > > > > Regards, > > Florian > > > > > > [0] https://bugzilla.gnome.org/show_bug.cgi?id=652459#c13 > > [1] https://bugzilla.gnome.org/show_bug.cgi?id=672543 > > > > 2 or 3 lines sounds safe to me, and this bug is a pretty visible wart > in a new feature. So, approval 1 for the release team.
Approval 2 of 2 if the proper patch gets applied soonish after the 3.4.0 tarball. andre -- mailto:ak...@gmx.net | failed http://blogs.gnome.org/aklapper _______________________________________________ release-team@gnome.org http://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.