Hey, I'd like to get approval to land patches for the following bugs:
(1) https://bugzilla.gnome.org/show_bug.cgi?id=708218 The (alt-f2) run dialog is disabled when the screen is locked; however, if the dialog is already open at that point (e.g. automatic lock after a timeout), then the prompt will still be available on top of the screen shield. We definitively don't want the ability to run arbitrary commands in a locked session, so we should close the dialog in that case. The patch in question is small and simple, which should make it very safe. (2) https://bugzilla.gnome.org/show_bug.cgi?id=708324 / https://bugzilla.gnome.org/show_bug.cgi?id=706577 Both network and keyring password prompts can grow too wide horizontally (and even overflow the dialog itself) - bug 706577 has a screenshot, and bug 708324 is easy to reproduce. Admittedly this is a polish issue (e.g. the dialogs' functionality is not affected), but it looks obviously broken. The patches in bug 708324 are trivial and safe, however they require two additional patches from https://bugzilla.gnome.org/show_bug.cgi?id=703833, which port the dialogs from our private StTable widget to a "standard" ClutterTableLayout. While the patches themselves are fairly small and straightforward as well, there is an obvious risk in swapping one widget implementation by another one, even with both having a common ancestry. I have been running with the patches applied locally without any obvious regressions since early July though, so I do think that the benefits outweigh this risk. Cheers, Florian _______________________________________________ [email protected] https://mail.gnome.org/mailman/listinfo/release-team Release-team lurker? Do NOT participate in discussions.
