On Mon, 2016-09-19 at 17:00 +0200, Frederic Peters wrote:
> Style-wise the maybe-else part cut by #endif is quite ugly; but ok,
> first approval nevertheless.

2/2, but consider this solution to avoid the weird placement of the
preprocessor conditionals:

#ifdef HAVE_LIBWACOM
  if (info->wacom_device)
    id = g_strdup_printf (...);
#endif

  if (!id)
    id = g_strdup_printf (...);
_______________________________________________
release-team@gnome.org
https://mail.gnome.org/mailman/listinfo/release-team
Release-team lurker? Do NOT participate in discussions.

Reply via email to