On mardi 6 février 2018 03:24:27 CET Nicolás Alvarez wrote: > 2018-02-05 19:40 GMT-03:00 Luca Beltrame <lbeltr...@kde.org>: > > Il giorno Mon, 05 Feb 2018 18:55:52 +0100 > > > > David Faure <fa...@kde.org> ha scritto: > >> I certainly didn't intend to re-enable it. Are you sure that I did ? > > > >> I can't see the commit, and I still see this code in file_unix.cpp : > > I see, was some commit overwritten? I saw > > https://commits.kde.org/kio/2013f14d82efdedce49b2959d1bb56e53cff897c > > flying by, but it's no longer viewable in cgit. > > > > Archived post: https://marc.info/?l=kde-commits&m=151765309314964&w=2 > > I investigated this in server logs. It looks like David attempted to > push that commit, and our hooks may have spuriously sent email for it, > but it didn't actually make it to the repository. Perhaps he Ctrl-C'd > the push after the commit data was sent to the server but before > refs/heads/master was updated to contain it.
Ah yes, exactly, I Ctrl-C'ed a push when I saw that it had the unwanted revert in it. Sorry for the trouble, I thought I had aborted it in time for no damage to be done. Good thing the mailing happens before the updating of master instead of the other way around [which would be a way to silently push things]. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5