On Mon, 29 Jan 2018 00:46:25 +0100 doak <d...@posteo.net> wrote: > Dear Replicant developers, Hi,
> in reference to issue [#1870] I made the creation of certificates
> ('./vendor/replicant/sign-build') more robust. Please find the
> patches attached. Let me know if they need some rework to be
> accepted. Feel free to accept only some of them as well.
I've looked rapidly at the first patch, and they seem great.
However it would be easier to review and comment on the patch if they
were sent like that:
- One mail for the message you wrote
- One mail per patch in response to this message, with the mail inside
the message body.
The git-send-email program (which is part of git) is able to do that.
for instance for Replicant it would look like that:
git-send-email --compose \
--to="replicant@osuosl.org" \
--to="Denis 'GNUtoo' Carikli <gnu...@no-log.org>" \
0001-Add-output-messages.patch \
0002-Formatting-Split-all-arguments-into-seperate-lines.patch \
0003-Make-creation-of-certificates-more-robust.patch \
0004-Do-not-leave-certificates-creation-in-undefined-stat.patch
As for the account settings, see the EXAMPLE section of git-send-email.
I'm very interested in having a robust build system as it makes the job
of new developers easier. On a build computer, I even had an issue that
the patches are supposed to fix (incomplete certificate generation ->
impossible to sign images).
Denis.
pgp_Nl7UejPOO.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant
