Hi,
Denis 'GNUtoo' Carikli:
> On Sun, 2 Sep 2018 21:17:21 +0200
> Fil <fil.berg...@riseup.net> wrote:
>
>> From e17c05cfe9665ff1ec9dffbf46f90be18e44fa3d Mon Sep 17 00:00:00 2001
>> From: Fil Bergamo <fil.berg...@riseup.net>
>> Date: Sun, 2 Sep 2018 16:44:44 +0000
>> Subject: [PATCH] fix #1853 "Ecryption" typo in Settings App
> Maybe mention the fact that the #1853 is a bug.
> Something like that would be better:
>> fix bug #1853 ("Ecryption" typo in Settings App)I researched online this topic a bit and maybe providing ticket ID in commit message is not so good idea: <https://hackernoon.com/on-git-commit-messages-and-issue-trackers-f700f3cbb5a7?gi=1821111258f>. The article mentions that issue tracker could change in future therefore making those IDs in Git meaningless. As we don't publish and review our patches in the issue tracker it means that if one wants to sent patch to this mailing list they must also mention in a cover letter / patch which issue the patch addresses but we would have to do it anyways since one needs to tell also to what repository the patch is for. So I don't think it is a big deal to drop the ticket ID from the commit message. What I suggest for the commit message is "Fix "Ecryption" typo". Joonas
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant
