On Wed, 15 Jul 2020 19:12:40 +0200
Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org> wrote:

While rebasing some patches on top of this one I found the following
issue:
[...]
> diff --git a/samsung-ipc/devices/ipc_devices.c
> b/samsung-ipc/devices/ipc_devices.c index 73f2914..fc767e0 100644
> --- a/samsung-ipc/devices/ipc_devices.c
> +++ b/samsung-ipc/devices/ipc_devices.c
> @@ -20,8 +20,7 @@
>  #include <stdlib.h>
>  
>  #include <samsung-ipc.h>
> -
> -#include "ipc_devices.h"
> +#include "devices/ipc_devices.h"

Here that produces the following result:
> #include <samsung-ipc.h>
> #include "devices/ipc_devices.h"

Instead we want to add a space between both lines to distinguish between
the include that is publicly exported (samsung-ipc.h) and the includes
internal to libsamsung-ipc.

This looks better:
> #include <samsung-ipc.h>
>
> #include "devices/ipc_devices.h"

I'll incorporate that fix before pushing the patch.

Denis.

Attachment: pgpJngD0BXBqX.pgp
Description: OpenPGP digital signature

_______________________________________________
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant

Reply via email to