- The includes were ordered alphabetically - #include "" is prefered over #incude <> for files relative to a given project[1] (here libsamsung-ril).
References: ----------- [1]In the C standard[2], the difference of behavior of between #include <> and #include "" is implementation-defined[2]. And The GCC documentation[3] says that #include "" "is used for header files of your own program.". [2]The standard doesn't seem to be available for free, but the draft can be downloaded from the following URL: https://web.archive.org/web/20181230041359if_/http://www.open-std.org/jtc1/sc22/wg14/www/abq/c17_updated_proposed_fdis.pdf [3]https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html Signed-off-by: Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org> --- srs.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/srs.c b/srs.c index 4a11564..1f6c320 100644 --- a/srs.c +++ b/srs.c @@ -17,26 +17,27 @@ * along with Samsung-RIL. If not, see <http://www.gnu.org/licenses/>. */ -#include <stdlib.h> #include <errno.h> #include <fcntl.h> +#include <stdlib.h> + +#include <sys/eventfd.h> +#include <sys/select.h> +#include <sys/socket.h> #include <sys/stat.h> #include <sys/types.h> -#include <sys/socket.h> #include <sys/un.h> -#include <sys/select.h> -#include <sys/eventfd.h> #include <arpa/inet.h> -#include <netinet/in.h> #include <cutils/sockets.h> +#include <netinet/in.h> #define LOG_TAG "RIL-SRS" #include <utils/Log.h> #include <hardware_legacy/power.h> -#include <samsung-ril.h> -#include <utils.h> +#include "samsung-ril.h" +#include "utils.h" /* * Utils -- 2.28.0 _______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant
