On Tue, 1 Dec 2020 19:14:53 +0200 Joonas Kylmälä <joonas.kylm...@iki.fi> wrote:
> Hi, Hi, > Denis 'GNUtoo' Carikli: > > --- /dev/null > > +++ b/guix.scm > > @@ -0,0 +1,194 @@ > > +;;; Copyright © 2020 Denis Carikli <gnu...@cyberdimension.org> > > +;;; > > +;;; This file is not part of GNU Guix (yet). > > +;;; > > +;;; Part of this file might be moved to Guix when a new release of > > +;;; libsamsung-ipc is made. This will probably not happen before > > +;;; the API and ABI changes are complete, ie when the ipc_client > > +;;; has been passed to all the exported functions when that makes > > +;;; sense. > > It would be better to move these code comments only after the > copyright and license info instead of putting in between. Thanks a lot for spotting that. Theses are left over from a package file: I started that quite some time ago by doing a package file: I was at the time abusing the package system to do build tests of libsamsung-ril, and also libsamsung-ipc, since it's one of its dependencies. This helped me a lot during the conversion from libsamsung-ril to Android >=9 as it made things so much faster as I could manage to isolate things to convert very fast and do build tests very fast too. But then I learn about the Guix.scm convention (which does exactly what I was trying to achieve in the first place) in the video you mentioned (it's the same video that is mentioned in the commit message). However I forgot to change the comments. In addition the comments makes it really misleading as they talk about a package. > > +;;; This file is free software; you can redistribute it and/or > > modify it +;;; under the terms of the GNU General Public License as > > published by +;;; the Free Software Foundation; either version 3 of > > the License, or (at +;;; your option) any later version. > > +;;; > > +;;; This file is distributed in the hope that it will be useful, > > but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of > > +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +;;; GNU General Public License for more details. > > +;;; > > +;;; You should have received a copy of the GNU General Public > > License +;;; along with GNU Guix. If not, see > > <http://www.gnu.org/licenses/>. > > along with GNU Guix -> should be libsamsung-ipc and also most of the > libsamsung-ipc programs are gplv2+ not gplv3+. The only odd file with > GPLv3 directly related to libsamsung-ipc that was so far gplv3+ is > Android.mk file that came from commit "Android.mk cleanup" > (977dcdef11) probably by accident? Please see also commit ed87346. If I recall well, the rationale behind this commit (ed87346 switch to GPLv2+ as license as decided by all authors per mail) was that oFono refused the patch to add support for libsamsung-ipc on the basis of its license (GPLv3+). Since that's now fixed, once the API change is completed, we[1] could then try again to upstream that patch. My rationale for putting the Guix.scm directly under GPLv3+ was that since Guix is under GPLv3+, and that the Guix.scm is not used at all in the final library, it is not an issue. There is also no risk of it being moved other to the library. Thanks a lot, I'll fix the comment issue and resend it. References: ----------- [1] We here means anyone interested in upstreaming that patch. Denis.
pgp5S6OyMy136.pgp
Description: OpenPGP digital signature
_______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant
