This enables to distinguish different kind of loop failures. The loop handler comes directly from libsamsung-ipc device drivers, which in turn wrap the vendor kernel interfaces.
Given that there is some possible variation between the way that the .loop implementations behaves, it's a good idea to add prints to understand better what is going on in case of issues. With the development of a new set of kernel drivers and libsamsung-ipc device driver for Replicant 11, we had a situation where that code was triggered. Note that, at the time of writing, we are not (yet) aware of any behavior difference with the different .loop implementations, but it would be worth checking if they all behave in the same way. Signed-off-by: Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org> --- ipc.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/ipc.c b/ipc.c index 1a6c877..e41823f 100644 --- a/ipc.c +++ b/ipc.c @@ -445,14 +445,24 @@ int ipc_fmt_loop(struct ril_client *client) if (fds.fds[0] == data->event_fd && fds.count > 0) { rc = eventfd_recv(data->event_fd, &event); - if (rc < 0) + if (rc < 0) { + RIL_LOGE("Receiving %s data with eventfd_recv " + "failed with error %d", + client->name, rc); goto error; + } switch (event) { case IPC_CLIENT_CLOSE: + RIL_LOGE("Closing %s due to " + "IPC_CLIENT_CLOSE", + client->name); rc = 0; goto complete; case IPC_CLIENT_IO_ERROR: + RIL_LOGE("Exiting %s due to " + "IPC_CLIENT_IO_ERROR", + client->name); goto error; } } -- 2.30.1 _______________________________________________ Replicant mailing list Replicant@osuosl.org https://lists.osuosl.org/mailman/listinfo/replicant