Without that fix we have the following warning:
../../../samsung-ipc/devices/crespo/crespo.c:
In function 'crespo_gprs_get_iface':
../../../samsung-ipc/devices/crespo/crespo.c:587:9: warning:
ignoring return value of 'asprintf' declared with attribute
'warn_unused_result' [-Wunused-result]
587 | asprintf(&iface, "%s%d", CRESPO_GPRS_IFACE_PREFIX, cid - 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Denis 'GNUtoo' Carikli <gnu...@cyberdimension.org>
---
samsung-ipc/devices/crespo/crespo.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/samsung-ipc/devices/crespo/crespo.c
b/samsung-ipc/devices/crespo/crespo.c
index 27e1dd5..5399e77 100644
--- a/samsung-ipc/devices/crespo/crespo.c
+++ b/samsung-ipc/devices/crespo/crespo.c
@@ -584,11 +584,16 @@ char *crespo_gprs_get_iface(__attribute__((unused))
struct ipc_client *client,
unsigned int cid)
{
char *iface = NULL;
+ int rc;
if (cid > CRESPO_GPRS_IFACE_COUNT)
return NULL;
- asprintf(&iface, "%s%d", CRESPO_GPRS_IFACE_PREFIX, cid - 1);
+ rc = asprintf(&iface, "%s%d", CRESPO_GPRS_IFACE_PREFIX, cid - 1);
+ if (rc == -1) {
+ ipc_client_log(client, "%s: asprintf failed", __func__);
+ return NULL;
+ }
return iface;
}
--
2.36.1
_______________________________________________
Replicant mailing list
Replicant@osuosl.org
https://lists.osuosl.org/mailman/listinfo/replicant
