Your message dated Wed, 12 Aug 2009 09:55:25 +0000
with message-id <[email protected]>
and subject line Bug#535789: fixed in reportbug 4.6
has caused the Debian Bug report #535789,
regarding reportbug crash when trying to detach a not attached file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
535789: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=535789
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: reportbug
Version: 4.4
Severity: normal
Tags: patch


I was reporting a bug with reportbug, and click 'd' to detach a file. Then, I
regret and hit enter (without writing anything) and reportbug crash with:

Select the file:
Traceback (most recent call last):
  File "/usr/bin/reportbug", line 1877, in <module>
    main()
  File "/usr/bin/reportbug", line 895, in main
    return iface.user_interface()
  File "/usr/bin/reportbug", line 1819, in user_interface
    charset=charset)
  File "/usr/bin/reportbug", line 254, in handle_editing
    attachments.remove(filetodetach)
ValueError: list.remove(x): x not in list


I made two different patches to fix this (both attached).

One just removes the "empty_ok" option, so only valid files are accepted (so not
detaching anything is not an option once you click 'd'). The other one checks if
the file is in the list, if it is it removes it, and if its not, it does not
detach anything (so if you just click enter, you dont detach anything).

I didn't check if there is any option more covenient in ui.menu, I have to go
right now.




Thanks a lot,
Rodrigo


-- Package-specific info:
** Environment settings:
INTERFACE="text"

** /home/rodrigo/.reportbugrc:
reportbug_version "3.31"
mode novice
ui text
email "[email protected]"
no-cc
header "X-Debbugs-CC: [email protected]"
smtphost bugs.debian.org

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable'), (400, 'unstable'), (200, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.30-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages reportbug depends on:
ii  apt                           0.7.21     Advanced front-end for dpkg
ii  python                        2.5.4-2    An interactive high-level object-o
ii  python-reportbug              4.4        Python modules for interacting wit

reportbug recommends no packages.

Versions of packages reportbug suggests:
pn  debconf-utils                 <none>     (no description available)
ii  debsums                       2.0.44     verification of installed package 
pn  dlocate                       <none>     (no description available)
ii  exim4                         4.69-11    metapackage to ease Exim MTA (v4) 
ii  exim4-daemon-light [mail-tran 4.69-11    lightweight Exim MTA (v4) daemon
ii  file                          5.03-1     Determines file type using "magic"
ii  gnupg                         1.4.9-4    GNU privacy guard - a free PGP rep
pn  python-gnome2-extras          <none>     (no description available)
ii  python-gtk2                   2.14.1-3   Python bindings for the GTK+ widge
pn  python-urwid                  <none>     (no description available)
pn  python-vte                    <none>     (no description available)

-- no debconf information
--- /usr/bin/reportbug  2009-05-25 15:15:08.000000000 -0300
+++ reportbug   2009-07-04 23:51:05.000000000 -0300
@@ -251,8 +251,11 @@
                 myattachments = [(x, '') for x in attachments]
                 filetodetach = ui.menu(detachprompt, myattachments,
                     'Select the file:', default='', empty_ok=True)
-                attachments.remove(filetodetach)
-                ewrite('Attachment file successfully detached.\n')
+                if filetodetach in attachments:
+                    attachments.remove(filetodetach)
+                    ewrite('Attachment file successfully detached.\n')
+                else:
+                    ewrite('Not detaching anything.\n')
         elif x == 'c':
             ed = ui.get_filename('Choose editor: ', default=options.editor)
             if ed:
--- /usr/bin/reportbug  2009-05-25 15:15:08.000000000 -0300
+++ reportbug   2009-07-05 00:13:16.000000000 -0300
@@ -250,7 +250,7 @@
                 myattachments = []
                 myattachments = [(x, '') for x in attachments]
                 filetodetach = ui.menu(detachprompt, myattachments,
-                    'Select the file:', default='', empty_ok=True)
+                    'Select the file:', default='')
                 attachments.remove(filetodetach)
                 ewrite('Attachment file successfully detached.\n')
         elif x == 'c':

--- End Message ---
--- Begin Message ---
Source: reportbug
Source-Version: 4.6

We believe that the bug you reported is fixed in the latest version of
reportbug, which is due to be installed in the Debian FTP archive:

python-reportbug_4.6_all.deb
  to pool/main/r/reportbug/python-reportbug_4.6_all.deb
reportbug_4.6.dsc
  to pool/main/r/reportbug/reportbug_4.6.dsc
reportbug_4.6.tar.gz
  to pool/main/r/reportbug/reportbug_4.6.tar.gz
reportbug_4.6_all.deb
  to pool/main/r/reportbug/reportbug_4.6_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sandro Tosi <[email protected]> (supplier of updated reportbug package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 12 Aug 2009 10:57:03 +0200
Source: reportbug
Binary: reportbug python-reportbug
Architecture: source all
Version: 4.6
Distribution: unstable
Urgency: low
Maintainer: Reportbug Maintainers <[email protected]>
Changed-By: Sandro Tosi <[email protected]>
Description: 
 python-reportbug - Python modules for interacting with bug tracking systems
 reportbug  - reports bugs in the Debian distribution
Closes: 166168 222621 304006 376810 414554 427560 435818 451041 529251 535560 
535789 536873 537449 537624 537929 538021
Changes: 
 reportbug (4.6) unstable; urgency=low
 .
   * reportbug/__init__.py
     - bump reportbug version
   * bin/querybts
     - allows to specify multiple bugs number with --mbox; thanks to Trent Buck
       for the report and Carl Chenet for the patch: Closes: #427560
   * reportbug/submit.py
     - added support for gnupg-agent with signing emails; thanks to Mathias
       Brodala or the report and Carl Chenet for the patch: Closes: #435818
   * bin/reportbug
     - allow ENTER to exit from file detaching menu (and enforced file 
checking);
       thanks to Rodrigo Campos for report and (partial) patch; Closes: 535789
     - do not exit if no subject is entered for new bugs, but keep asking it;
       thanks to Olaf van der Spek for the report and Carl Chenet for the patch;
       Closes: #537449
     - do not exit if no subject is entered for additional information, but keep
       asking it; thanks to Carl Chenet for the report and patch: Closes: 
#537624
     - configuration asks also if 'smtptls' is needed or not; thanks to Jerome
       Reybert for the report; Closes: #538021
     - allow to add tags to the bug even in the last menu (right before 
sending);
       thanks to Enrico Zini for the report and Carl Chenet for the patch;
       Closes: #304006
   * bin/querybts, man/querybts.1, reportbug/ui/text_ui.py
     - querybts is now able to handle multiple bug numbers, package names or any
       mix of them when using --mbox option; thanks to Carl Chenet for the 
report
       and patch; Closes: #535560
     - added -b/--buglist option to display a bugs list for the given package;
       thanks to Andrew Ferrier for the report and Carl Chenet for the patch;
       Closes: #222621
   * bin/reportbug, reportbug/ui/text_ui.py
     - provide a default reply subject ('Re: ' + <original subject>) when
       providing additional information to a bug report; thanks to Carl Chenet
       for the report and patch; Closes: #537929
   * reportbug/ui/text_ui.py
     - allow to open a browser with the complete packages' bugs list; thanks to
       Eduard Bloch for the report and to Carl Chenet for the patch;
       Closes: #166168
     - expand the ~ or any other environment variables in attachment file name;
       thanks to Andreas Pakulat, Raúl Sánchez Siles, Emil Nowak for the reports
       and to Carl Chenet for the patch; Closes: #376810, #414554, #451041
   * reportbug/submit.py, reportbug/ui/text_ui.py
     - if MUA returns an error, notify the user allowing to re-edit the mail
       (without loosing the mail); thanks to Raphaël Hertzog for the report and
       to Carl Chenet for the patch; Closes: #529251
   * reportbug/urlutils.py, debian/control
     - use xdg-open instead of sensible-browser to open URLs: it uses the
       selected browser in the desktop environment, else it falls back to s-b;
       thanks to Alexandre Fournier for the report; Closes: #536873
Checksums-Sha1: 
 19b2ea7de6f358f19f602d697b6bba826c174593 1124 reportbug_4.6.dsc
 47ad475f636c017ebcdbdfa1b3d6a6aa3e22d2b7 196050 reportbug_4.6.tar.gz
 2692cec133d169eae400f6dbb9603ead50c66c16 121334 reportbug_4.6_all.deb
 48f566971b463c7af4ae7f18cb1a992a5f20f2d1 115990 python-reportbug_4.6_all.deb
Checksums-Sha256: 
 f4063d14d5682d602a0ddd9f7391590a4df30e65d0d67060e5b464d68e1c5a9e 1124 
reportbug_4.6.dsc
 44ef47a4ad3f258c2b00d81b3f3ec8e79b2628bc490b9924c3c71e1e7f49094e 196050 
reportbug_4.6.tar.gz
 fec9ebf269cb0504bffcee6fa180533894296b874dc8039140b193f7237a028b 121334 
reportbug_4.6_all.deb
 66652453cd9cef4a6bb710d52ee24b2f51a6c571311e3c101b4e2e98bca6ff38 115990 
python-reportbug_4.6_all.deb
Files: 
 162ff9a0c7048e3ddd407de01a2e3aaf 1124 utils standard reportbug_4.6.dsc
 464806b26129175d7a8148e9372d4568 196050 utils standard reportbug_4.6.tar.gz
 f8ee5d46274e61adc85840ba614e89de 121334 utils standard reportbug_4.6_all.deb
 53bc1f428251c1c517b293d26df2061f 115990 python standard 
python-reportbug_4.6_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqChZgACgkQAukwV0RN2VCk2gCgmxlLGaXhR5JAujBpDmmP2QYR
zwoAn1vIeBFKqe0Ft37piLO1ySoygI85
=3n1j
-----END PGP SIGNATURE-----



--- End Message ---
_______________________________________________
Reportbug-maint mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/reportbug-maint

Reply via email to