On Fri, May 13, 2016 at 12:44:11PM +0200, Ximin Luo wrote: > Concretely I have some suggestions: > > 1. instead of calling this "ignore" we call it "hide". and instead of > "irrelevant" we say "common"/"minor"/"known" strong ACK.
I really really like "--hide-timestamps" much better than
"--ignore-timestamps", because the latter somewhat implies that ignoring
this is ok, while hiding clearly conveys there is something, hidden.
> 2. diffoscope --ignore-* (or --hide-*) MUST NOT return 0 or otherwise give
> the impression that two non-identical files are the same, even if all
> differences are "hidden". It should report "n differences hidden".
hm. maybe it would be ok to exit with 0 when using --hide options if one
also adds _another_ option, like --hide-error-on-exit or
--pretend-clean-if-hidden-well or such?
--
cheers,
Holger
signature.asc
Description: Digital signature
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
