Source: proj Version: 4.9.2-2 Severity: wishlist Tags: patch upstream User: reproducible-builds@lists.alioth.debian.org Usertags: toolchain X-Debbugs-Cc: reproducible-builds@lists.alioth.debian.org
Dear Maintainer, While working on the “reproducible builds” effort [1], we have noticed that the nad2bin binary has unreproducible output, as it includes uninitialized memory state when CTABLE.id's length is less than the available 80 bytes. See the attached patch for a proposed solution. Regards, Alexis Bienvenüe. [1] https://wiki.debian.org/ReproducibleBuilds
Description: Makes nad2bin output reproducible Init CTABLE.id char[80] variable with zeroes, so that nad2bin output does not depend on memory state before call, and hence be reproducible. Author: Alexis Bienvenüe <p...@passoire.fr> --- proj-4.9.2.orig/src/nad2bin.c +++ proj-4.9.2/src/nad2bin.c @@ -98,6 +98,7 @@ int main(int argc, char **argv) { /* Read the ASCII Table */ /* ==================================================================== */ + memset(ct.id,0,MAX_TAB_ID); if ( NULL == fgets(ct.id, MAX_TAB_ID, stdin) ) { perror("fgets"); exit(1);
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds