Ximin Luo:
> Ximin Luo:
>> I'm going to suggest SOURCE_ROOT_DIR [..]
> 
> OTOH, taking into account dkg's earlier point about overloading
> "root", perhaps SOURCE_BASE_DIR would be better.
> 
> It is used quite heavily:
> 
> https://codesearch.debian.net/search?q=\bSOURCE_BASE_DIR\b
> 
> but only by cmake files:
> 
> https://codesearch.debian.net/search?q=\bSOURCE_BASE_DIR\b+-path%3A.cmake%24+-path%3ACMakeLists.txt%24
> 
> However, they seem to use this to mean the same thing as what we want,
> so it could actually be an argument in favour of us using the name
> too. (I've not seen how it works for subprojects, I will have to dig
> deeper for that.)

I disagree. Using something already used will hit back in someway.
I did not look closely at the CMake files but it looks like this means
something else if for some reason the their SOURCE_BASE_DIR isn't at the
toplevel.

If you like SOURCE_BASE_DIR, why not SOURCE_BASE_DIRECTORY [0].

[0]: https://codesearch.debian.net/search?q=\bSOURCE_BASE_DIRECTORY\b

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Reproducible-builds mailing list
Reproducible-builds@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds

Reply via email to