Mattia Rizzolo: > On Sun, Nov 06, 2016 at 10:04:00PM +0000, HW42 wrote: >> (As I wrote an hour ago on irc,) See last 3 commit at >> https://anonscm.debian.org/git/users/hw42-guest/jenkins.debian.net.git/ > > >> commit fdb7a50073ef9e3b8d22176b63817a78c928d73c >> Author: HW42 <h...@ipsumj.de> >> Date: Sun Nov 6 18:30:46 2016 +0100 >> >> reproducible Debian: always build under /build >> >> This way the build-path gets included into the .buildinfo like it will >> on buildds. > > This was (non-intentionally, and not sure whether anybody realized) done > due to the same reason we are not including Environment. > After this you could also just remove that code from Reiner from the > other day as well... > >> commit 3c400e29acfa961e240986771159ff1d5637ebf0 >> Author: HW42 <h...@ipsumj.de> >> Date: Sun Nov 6 21:20:35 2016 +0100 >> >> reproducible Debian: adapt for non identical .buildinfos >> >> .buildinfo document part of the build environment and are not expected >> to be the same for the two builds. > > I see that Holger already merged this, but: > > Did anybody checked the git history to see why this was done? > > Now that we're comparing .changes again diffoscope will walk through the > packages twice, once through .changes→.deb and once through > .changes→.buildinfo→.deb, doubling the comparing time and so causing > timeouts in a lot more packages (and we already have a lot of them).
I removed the filter from Reiner and replaced it with a 'sed' filtering out the .buildinfo entries from the .changes file. So diffoscope should not compare the .buildinfos (and the files refered by them) at all. > I'll file a diffoscope bug after this email. Once diffoscope has a --ignore-buildinfo options for comparing .changes you can just drop the filter_changes_files function and pass the option to diffoscope.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds